fix(db): never raise from the connect handler, and scale the budget test right - #124

Two failures from the post-merge run of 12842d28 (#123). One is a real defect I introduced in #122; the other is my test's scaling.

test-windows — a real handle leak

tests/test_highlevel.py::TestCaptureEdgeCases::test_capture_load_corrupt_db passed and then failed its own temporary-directory cleanup:

PermissionError: [WinError 32] The process cannot access the file because it is
being used by another process: '...\tmpw2fwt3c6\capture\recording.db'

get_engine asks each new connection for its journal mode so it can match synchronous to it. A corrupt file cannot answer, and that exception was raised inside the connect handler — which leaves the new connection outside the pool that would have closed it. engine.dispose() cannot reach it, and the file stays open. macOS and Linux happily delete an open file, so only Windows reported it.

Never raise from that handler. It is a tuning step, not a correctness one. A file that cannot answer it must fail on the caller's own statement instead, where the engine still owns the connection and disposes it.

test_a_corrupt_capture_database_leaves_no_open_handle pins this, and fails against the unguarded handler.

test-macos — my test's scaling, not the helper

The budget test measured 2.05s, then 2.22s, against declared worst cases of 2.0s and 2.2s.

An attempt costs its busy timeout plus a fixed overhead that does not shrink with it. A 0.2s ceiling against a 0.05s busy timeout is mostly that overhead, so one slow attempt overruns. Production deliberately keeps the ceiling several times the timeout (2.0s vs 0.5s); the test did not.

Scaled to match: 0.25s timeout, 1.0s ceiling, 5.0s budget.

No change to the retry helper in either case.

Still discriminating

Verified again with only the old retry policy restored: test_the_total_wait_never_runs_past_the_declared_budget and test_concurrent_writers_all_survive_a_busy_write_lock both fail, the other 14 pass.

Full suite: 722 passed, 33 skipped. ruff clean.